Re: [PATCH v6 2/7] submodule: don't pass empty string arguments to submodule--helper clone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 29, 2016 at 2:58 PM, Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote:
> From: Jacob Keller <jacob.keller@xxxxxxxxx>
>
> When --reference or --depth are unused, the current git-submodule.sh
> results in empty "" arguments appended to the end of the argv array
> inside git submodule--helper clone. This is not caught because the argc
> count is not checked today.
>
> Fix git-submodule.sh to only pass an argument when --reference or
> --depth are used, preventing the addition of two empty string arguments
> on the tail of the argv array.
>
> Signed-off-by: Jacob Keller <jacob.keller@xxxxxxxxx>

Reviewed-by: Stefan Beller <sbeller@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]