Re: [PATCH v6 28/32] config: read ref storage config on startup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 29, 2016 at 04:57:49PM -0500, David Turner wrote:

> > By the way, I notice that the default value for the_refs_backend is
> > "&refs_be_files". It might be safer to make this NULL (or some
> > &refs_be_null that fills the vtable, but just returns an error for
> > each
> > call).
> 
> In 'refs: register ref storage backends', I do make this change.  I
> don't do it earlier because we don't have this config stuff in place
> yet.

Ah, OK. I was that we did register the files backend as a normal one,
but I missed the assignment to NULL (I do wonder if we want a
refs_be_null to smoke out problem cases with a die("BUG") rather than
segfaulting, but in theory nobody should be doing that).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]