On Mon, Feb 29, 2016 at 07:30:02AM +0100, Torsten Bögershausen wrote: > I haven't digged further, > but trying to verify t9115 under Windows gave this: > > compat/mingw.c: In function 'mingw_spawnve_fd': > compat/mingw.c:1072:10: warning: implicit declaration of function > 'xmalloc_array' [-Wimplicit-function-declaration] > wargs = xmalloc_array(st_add(st_mult(2, args.len), 1), sizeof(wchar_t)); > ^ Yikes. -- >8 -- Subject: [PATCH] compat/mingw: brown paper bag fix for 50a6c8e Commit 50a6c8e (use st_add and st_mult for allocation size computation, 2016-02-22) fixed up many xmalloc call-sites including ones in compat/mingw.c. But I screwed up one of them, which was half-converted to ALLOC_ARRAY, using a very early prototype of the function. And I never caught it because I don't build on Windows. Signed-off-by: Jeff King <peff@xxxxxxxx> --- I think this means "master" is broken for mingw builds. Sorry, Windows people, for breaking your build. I'm happy to hold back such repo-wide cleanups from the mingw code in the future, since I can't actually compile them. But the flipside is that if I _do_ improve things, you don't get the benefit until somebody manually ports it over. compat/mingw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/mingw.c b/compat/mingw.c index cfedcf9..54c82ec 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1069,7 +1069,7 @@ static pid_t mingw_spawnve_fd(const char *cmd, const char **argv, char **deltaen free(quoted); } - wargs = xmalloc_array(st_add(st_mult(2, args.len), 1), sizeof(wchar_t)); + ALLOC_ARRAY(wargs, st_add(st_mult(2, args.len), 1)); xutftowcs(wargs, args.buf, 2 * args.len + 1); strbuf_release(&args); -- 2.8.0.rc0.276.gddf4100 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html