On 28 February 2016 at 10:25, <larsxschneider@xxxxxxxxx> wrote: > From: Lars Schneider <lars.schneider@xxxxxxxxxxxx> > > Map a P4 user to a specific name and email address in Git with the > "git-p4.mapUser" config. The config value must be a string adhering > to the format "p4user -> First Lastname <email@xxxxxxxxxxx>". Seems generally fine. I agree with Eric's comments about the "->" format. One comment below: > +test_expect_success 'Clone repo root path with all history' ' > + client_view "//depot/... //client/..." && > + test_when_finished cleanup_git && > + ( > + cd "$git" && > + git init . && > + git config --add git-p4.mapUser "mmax -> Max Mustermann <max@xxxxxxxxxx>" && > + git config --add git-p4.mapUser "mo -> Moritz Untreu <moritz@xxxxxxxxxx>" && Probably better to use more innocuous names. I'm not sure who these people are, but they might not appreciate being recorded forver in a git-p4 test script. Luke -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html