Hello Junio, On Sun, Feb 28, 2016 at 12:50 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > >> Please don't. A macro that hides "return" makes things harder to >> follow, not easier. I will consider it next time. > Having said that, I do think a higher-level macro that encapulates > the whole thing may not be such a bad idea, i.e. making the above > into > > DECLARE_GIT_GETTER(const char *, get_git_dir, git_dir) Yes, it is better. Will resend the patch. Thank you. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html