On 2016-02-26 19.29, Junio C Hamano wrote: > Torsten Bögershausen <tboegi@xxxxxx> writes: > >> CC combine-diff.o >> combine-diff.c: In function ‘diff_tree_combined’: >> combine-diff.c:1391: internal compiler error: Segmentation fault >> Please submit a full bug report, >> with preprocessed source if appropriate. >> See <URL:http://developer.apple.com/bugreporter> for instructions. >> make: *** [combine-diff.o] Error 1 >> >> Revert "use st_add and st_mult for allocation size computation" didn't fix it. >> I haven't digged deeper yet. > > Hmph, I am not quite sure what you meant by "I haven't digged > deeper"; I do not think you should be debugging Apple's compiler > (unless you have the source to it and that is your job to do so, > that is). > > In any case, merging the topic to 'master', and reverting that > commit will leave this only this change between 'master' and the > result. I do not immediately spot anything trickier in the > postimage compared to the preimage that may trickle a compiler bug, > but what would I know without the source ;-) > Digging means: run git bisect and report the commit. And this makes the compiler happy: Revert "tree-diff: catch integer overflow in combine_diff_path allocation" This reverts commit 5b442c4f2723211ce0d862571e88ee206bfd51bf. Test suite passes, ( except t9115, the 2 new test cases "svn.pathnameencoding=cp932". More info about that later) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html