Jeff King <peff@xxxxxxxx> writes:
> Sine the credential.helper key is a multi-valued config
s/Sine/Since/;
> diff --git a/credential.c b/credential.c
> index 7d6501d..aa99666 100644
> --- a/credential.c
> +++ b/credential.c
> @@ -63,9 +63,12 @@ static int credential_config_callback(const char *var, const char *value,
> key = dot + 1;
> }
>
> - if (!strcmp(key, "helper"))
> - string_list_append(&c->helpers, value);
> - else if (!strcmp(key, "username")) {
> + if (!strcmp(key, "helper")) {
> + if (*value)
> + string_list_append(&c->helpers, value);
> + else
> + string_list_clear(&c->helpers, 0);
> + } else if (!strcmp(key, "username")) {
I wondered why neither the existing code nor the updated one has a
check for !value, but this callback assumes no credential
configuration variable will ever be a boolean and rejects it
upfront, so this code before or after the change is safe.
Not pointing out anything that needs to be changed; demonstrating
that I did read this sufficiently well to say that I have reviewed
it ;-)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html