On 22 February 2016 at 04:49, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sun, Feb 21, 2016 at 11:14 PM, Peter Dave Hello > <hsu@xxxxxxxxxxxxxxxxxx> wrote: >> From: Peter Dave Hello <peterdavehello@xxxxxxxxxxxxxxxxxxxxxxxx> > > This "From:" line looks suspiciously incorrect. If anything, you'd > probably want to drop the line altogether or use: > > From: Peter Dave Hello <hsu@xxxxxxxxxxxxxxxxxx> Peter's commit (https://github.com/git/git/commit/15415c6e) had an author of 'peterdavehello@xxxxxxxxxxxxxxxxxxxxxxxx' (perhaps because the commit was generated through GitHub's interface?), and submitGit added it as an in-body 'From: ' line because it differed from the address used to send the email (hsu@xxxxxxxxxxxxxxxxxx - submitGit always uses the user's primary-email-address-in-GitHub to send the email). A 'noreply' address is obviously not wanted in this context though, so I've updated submitGit to disregard them when deciding whether or not to generate an in-body 'From: ' header: https://github.com/rtyley/submitgit/pull/29 Roberto -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html