Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 26 Feb 2016, at 10:26, Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> 
> On Thu, Feb 25, 2016 at 3:42 PM,  <larsxschneider@xxxxxxxxx> wrote:
>> +ifdef DEVELOPER
>> +       CFLAGS +=       -Werror \
>> +                               -Wdeclaration-after-statement \
>> +                               -Wno-format-zero-length \
>> +                               -Wold-style-definition \
>> +                               -Woverflow \
>> +                               -Wpointer-arith \
>> +                               -Wstrict-prototypes \
>> +                               -Wunused \
>> +                               -Wvla
> 
> With the exception of $(SCRIPTS) in Makefile, I think we prefer to
> avoid \ and have one addition per statement
> 
I guessed that because I actually looked through the makefile to find how you deal with line 
brakes. The problem here was that this line gets really long and then it is hard to see what 
warnings are enabled.
Would you be OK with using \ for readability here?

Thanks,
Lars--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]