Matthieu Moy: > Using "git send-email" normally does the right thing. You may want to > look at https://submitgit.herokuapp.com/ too. git send-email does not work as my institute proxy does not allow IMAP/SMTP connections. But I will take care of this from hence forward. > The commit message should not try to rephrase what the patch aleady > says. I am dropping this statement off because of one another reason which Eric Sunshine gave. > If you know you haven't finished, you may use WIP (work in progress) > instead of RFC in the title. I wasn't familiar with this tag. I will keep it in mind. And this is not included in Documentation/SubmittingPatches , so I will send a patch to include WIP tag. > "the git-config" is not proper English. You mean "a configuration file". > I'd write "the configuration variable `commit.verbose` can be set to > true". I actually was facing problem in phrasing it. Thanks for your suggestion. I will update this. >> + with git-config. > > Did you mean "git commit"? Sorry for my carelessness. I will update this. > Doesn't this override any value that --verbose or --no-verbose may > have set before? Yes, this was the problem. I have fixed it now. But there is a glitch. See below. Eric Sunshine: > On Thu, Feb 25, 2016 at 9:57 PM, Pranit Bauva <pranit.bauva@xxxxxxxx> wrote: >> From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001 >> From: Pranit Bauva <pranit.bauva@xxxxxxxx> >> Date: Fri, 26 Feb 2016 07:14:18 +0530 >> Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable >From hence forth I will take that into consideration. > Talking about this in the commit message misleads the reader into > thinking that there is some potential oddity going on where a careful > decision needs to be made about which variable to set, when that's not > in fact the case. The 'verbose' member of wt_status is just one > consumer of the "verbose" flag, not the sole consumer. Another > consumer is found in builtin/commit.c:cmd_commit(): > > if (verbose || > cleanup_mode == CLEANUP_SCISSORS) > wt_status_truncate_message_at_cut_line(&sb); > > So, it would not be correct for the configuration ever to set only > wt_status::verbose. > > Consequently, it would be better to drop this paragraph altogether > from the commit message, so as to avoid confusing readers. I guessed this parent-child behavior and I wanted the commit to sound like that but now that I read it again, I can understand that it might confuse readers who aren't familiar with the code base. > Some tests to consider: > > * commit.verbose unset This was working perfectly fine! > * commit.verbose=true This was working perfectly fine! > * commit.verbose=false This was working perfectly fine! > * --verbose overrides commit.verbose This was showing errors. So I now included an if statement and then placed the whole code after the method parse_and_validate_options() otherwise it would just ignore the behavior. Now even this is working perfectly fine. > * --no-verbose overrides commit.verbose This is a problematic one as currently `git-commit` does not have such a behavior. I tried printing value of `verbose` in both the cases ie. with `git commit` and `git commit --no-verbose` and in both of them it printed the value 0. So currently, the program won't understand the "overriding" nature. I have an idea for implementing this. We can keep the default nature to point out to 0 and `--no-verbose` to point to -1. But I guess this problem would have been faced/implemented in other part of the code. I will have to look in different parts of code and see how this has been done in those so as to maintain the practices followed with git. I am currently not quite familiar with `parse-options.c` so I will read about it. But you could help by pointing out specific commits or email threads which are related to `--no-verbose` option in other git commands to speed up the process. > I haven't fully digested builtin/commit.c, but the placement of this > new code seems suspect. My expectation would have been to see > git_commit_config() updated to recognize the new "commit.verbose" > variable. Am I missing something? I too had a lot of confusing regarding this. But it seems to me that the method git_commit_config() shows a "different" behavior and I don't think such "complicated" behavior is required for reading the boolean variable `commit.verbose`. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html