Re: [PATCH] refs: mark a file-local symbol as static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-02-25 at 19:28 +0000, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Hi David,
> 
> No, you are not having flashbacks - you forgot to make the
> register_ref_storage_backend() function static. ;-)

Oops!  Must have lost that in all of the rebasing!  Will fix, thanks.

> BTW, I still have two symbols showing as exported but not used,
> namely:
> 
>     $ diff nsc psc1
>     ...
>     32a35,36
>     > refs.o	- resolve_ref_unsafe_submodule
>     > refs/files-backend.o	- do_for_each_per_worktree_ref
>     $ 
> 
> Both of these symbols are used by the lmdb backend, so I'm assuming
> that
> they are part of the 'refs API' and will (may?) be used by other
> alternate
> reference backends. Is that the case?

Yes.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]