Jacob Keller <jacob.keller@xxxxxxxxx> writes: >>>> Add a git submodule--helper function which can be used to sanitize the >>>> GIT_CONFIG_PARAMETERS value to only allow certain settings. For now, >>>> restrict this to only credential.* settings. >>> >>> I guess for now that subset is fine and will be expanded over time? >> >> I think it is more like "we pass only what is known to be necessary >> and safe, and right now, credential.* are the only such variables." >> >> As the system evolves more, theoretically we might find more, but >> let's not phrase it as if expanding is a good thing and a longer >> term goal. >> > > I can reword the commit message to that effect. I think what you wrote was perfectly fine. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html