Re: [PATCH v5 25/27] refs: add LMDB refs storage backend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2016-02-20 at 20:14 +0700, Duy Nguyen wrote:
> On Fri, Feb 19, 2016 at 3:23 AM, David Turner <
> dturner@xxxxxxxxxxxxxxxx> wrote:
> > On Thu, 2016-02-18 at 15:50 +0700, Duy Nguyen wrote:
> > 
> > [snip]
> > 
> > Thanks; applied the above
> > 
> > > This permission makes me wonder if we need adjust_shared_perm()
> > > here
> > > and some other places.
> > 
> > So just add this after every mkdir?
> > 
> >         if (shared_repository)
> >                 adjust_shared_perm(db_path);
> > 
> 
> Another option is avoid mkdir entirely. Getting started page [1] says
> if you do mdb_open_env(.., "refs.lmdb", MDB_NOSUBDIR,..) then it will
> create two files refs.lmdb and refs.lmdb.lock. No need for the
> directory "refs.lmdb" just to contain two files.
> 
> [1] http://symas.com/mdb/doc/starting.html

Good idea.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]