Re: [PATCH] git config: do not create .git/ if it does not exist yet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> Hi,
>
> On Wed, 24 Feb 2016, Johannes Schindelin wrote:
>
>> I created a test and essentially duplicated Peff's finding: this is a
>> Windows-only issue.
>
> Indeed it is in our patches:
>
> 	https://github.com/git-for-windows/git/commit/3a4c37b22
>
> (short version: we carry some patches that simplify locking the config
> file before building on top of it, and somehow we agreed back in the days
> when this patch was written that it would be a good idea if that code
> created leading directories.)

The log message there says this:

    This is particularly important when calling

         git config -f /non/existing/directory/config ...

I think that the change should be ejected.

	cat >/non/existing/directory/file
	mkdir /non/existing/directory/dir

would fail, and I do not see any valid reason for "git config" to be
different.

> I will fix this issue in Git for Windows, but I still think that my patch
> brings a usability improvement: the error message is just so much more to
> the point (will submit v2 in a moment).

Thanks.  I think your patch in this thread is an improvement.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]