Re: [PATCH] push: shorten "push.default is unset" warning message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 23, 2016 at 11:05:08AM -0800, Junio C Hamano wrote:

> If most people are happy with "simple" (and certainly that was the
> assumption and hope behind the transtion we made at 2.0), we may be
> better off removing the warning altogether.  Keeping "and adopt the
> new behaviour" part pretends to be offering a chance to make an
> informed choice, but it will forever be unclear to the non-reader
> what the implication of not adopting the new behaviour is anyway, so
> overall we won't see reduced hits at stackoverflow with this change.

Yeah, this was my first thought on seeing Matthieu's patch. We inserted
that message to tell people about the impending change, and to catch any
stragglers even after the change had happened. At some point it simply
becomes obsolete history.

I dunno if that time is now or not. v2.3.0 (which actually flipped the
switch) is only a year old, but we've been showing the message since
v1.8.0, which is over 3 years old. Even Debian stable is way beyond
that. :)

So my inclination is to just rip out the warning entirely.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]