Re: [PATCH 1/3] t3034: add rename threshold tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 23, 2016 at 7:50 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis
> <felipeg.assis@xxxxxxxxx> wrote:
>> +       if [ 50 -le "$th0" ]; then
>> +               check_50=check_threshold_0
>> +       elif [ 50 -le "$th1" ]; then
>> +               check_50=check_threshold_1
>> +       elif [ 50 -le "$th2" ]; then
>> +               check_50=check_threshold_2
>> +       fi &&

Oh, I totally forgot to mention a few style issues:

1. use 'test' rather than '['
2. place 'then' on its own line
3. drop semicolon

    if test 50 -le "$th0"
    then
        ...
    elif test ...
    then
        ...
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]