On Tue, Feb 23, 2016 at 01:06:10PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > + /* > > + * We don't actually care what our cwd is; we chdir here just to > > + * be a friendly daemon and avoid tying up our original cwd. > > + * If this fails, it's OK to just continue without that benefit. > > + */ > > + chdir(dir); > > I fully do agree with this comment, but my copy of gcc and system > headers doesn't, unfortunately. > > credential-cache--daemon.c: In function 'init_socket_directory': > credential-cache--daemon.c:245:7: error: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Werror=unused-result] > chdir(dir); > ^ > cc1: all warnings being treated as errors > make: *** [credential-cache--daemon.o] Error 1 Ugh. Is: (void)chdir(dir); enough? Or do we have to do: if (chdir(dir)) ; /* nothing */ ? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html