[RFC/PATCH 0/1] Add an option to git-format-patch to record base tree info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, 

I am a developer of 0-Day kernel test infrastructure(It is a service and
test framework for automated regression-testing that intercepts linux kernel
development at its early stages [1]), and as proposed by developers in ksummit-discuss,
we have implemented a framework to test all patches sent to LKML, it could help
us to find out potential build/boot/regression errors as early as possible.

In order to test LKML patches on their correct trees, we need to know the
corresponding base tree info, such as git url, branch, base commit id, etc,
currently we did some guess works and it may apply patches to the wrong base
trees, leading to undesirable false positives.

The only clean solution is for the developers to include these base tree info in
their first [PATCH] email, so we propose to add an option "--base-tree-info" to
git-format-patch to record these info in cover letter or the first patch
(put it between the "---" marker line and the actual diff), we believe it would
also be useful for maintainers who use git to manage their projects.

The initial implementation only record the base(parent) commit SHA1 of the
first patch. Here is the example:

1) with cover letter

you could see the commit id at the bottom of the message.

2) without cover letter

	Signed-off-by: Xiaolong Ye <xiaolong.ye@xxxxxxxxx>
	---
	 builtin/log.c | 17 +++++++++++++++++
	 diff.c        |  4 ++++
	 diff.h        |  3 ++-
	 revision.h    |  1 +
	 4 files changed, 24 insertions(+), 1 deletion(-)

	base commit: 0233b800c838ddda41db318ee396320b3c21a560

	diff --git a/builtin/log.c b/builtin/log.c
	index 0d738d6..49fe8c2 100644
	--- a/builtin/log.c
	+++ b/builtin/log.c


What do you think? Any review comments about this patch or any suggestions
to us would be greatly appreciated.

[1] https://01.org/lkp/documentation/0-day-test-service

Thanks,
Xiaolong.

Xiaolong Ye (1):
  format-patch: add an option to record base tree info

 builtin/log.c | 18 ++++++++++++++++++
 diff.c        |  4 ++++
 diff.h        |  3 ++-
 revision.h    |  1 +
 4 files changed, 25 insertions(+), 1 deletion(-)

base commit: 0233b800c838ddda41db318ee396320b3c21a560

-- 
2.7.1.340.gf1cebb4

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]