On Fri, Feb 19, 2016 at 02:33:10PM -0500, Jeff King wrote: > On Fri, Feb 19, 2016 at 07:23:11PM +0000, John Keeping wrote: > > > I suspect that any grep that lacks "-a" also lacks binary file handling > > that will break these tests. I found a Solaris grep that doesn't > > support "-a" and it treats these files as text. > > > > From that perspective, it would be better to have a central place that > > deals with figuring out how to get grep to work for us. Perhaps we need > > test_grep to get this right. We already have test_cmp_bin() as a thin > > wrapper around cmp so I don't think this is completely unprecedented. > > I think 99% of the time we are using grep for ascii text. As evidenced > by the number of test failures we see with the new grep, it is a small > minority that feed binary gibberish. I'd prefer if "-a" handling didn't > need to pollute anything outside of this narrow range of tests (and as > with my prereq suggestion, I am even find just skipping this narrow > range of tests on platforms with no "-a", though falling back to running > without "-a" is fine if it works). I went with using sed in this series because it seems to be the simplest and most compatible way to extract lines from the input. We don't need any special casing to figure out if an implementation needs "-a" or if it doesn't support that option and all the implementation I tested support the constructs used here. John Keeping (2): t8005: avoid grep on non-ASCII data t9200: avoid grep on non-ASCII data t/t8005-blame-i18n.sh | 16 ++++++++-------- t/t9200-git-cvsexportcommit.sh | 2 +- 2 files changed, 9 insertions(+), 9 deletions(-) -- 2.7.1.503.g3cfa3ac -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html