Kazutoshi Satoda <k_satoda@xxxxxxxxxxxxx> wrote: > (Shouldn't the branch be based on maint, as these are bugfixes?) I'm not sure if it being previously left-out/untested feature would qualify for maint. Maybe it does, but I suppose I'll let Junio decide. > Thank you. I tried it but got similar problem: <snip> > I found how "\357\202\201\357\202\202" (U+F081 U+F082 in UTF-8) could > come. > https://cygwin.com/cygwin-ug-net/using-specialnames.html#pathnames-specialchars > > Some characters are disallowed in filenames on Windows filesystems. ... > ... > > ... All of the above characters, except for the backslash, are converted > > to special UNICODE characters in the range 0xf000 to 0xf0ff (the > > "Private use area") when creating or accessing files. > "U+F081 U+F082" seems the result of conversion from "0x8182" (neq in > cp932) as treating each of 2 bytes as disallowed characters. > > And I also noticed that LANG and LC_ALL is set to "C" in test-lib.sh. > > Setting LC_ALL=C.UTF-8 in the test 11-12 made them pass on Cygwin. > Same change made the previous version also pass. Please find the patch > in the attached output of git format-patch. Thanks. However, I also wonder what happens on machines without "C.UTF-8" support (are there still any?). > Could you please test with this on non-Cygwin environment? Works for me, at least. I've squashed your changes into the two patches already queued up. I needed to split the "export LC_ALL=C.UTF-8" statement into "LC_ALL=C.UTF-8 && export LC_ALL" for portability. > If it made no harm, please tell me what should I do to proceed this patch. > Will you (Eric) please make further integration? Shall I make another > series (v2) of patches? I've pushed out a new branch with your LC_ALL changes squashed in. However I'm unsure if there's any new portability problems with LC_ALL=C.UTF-8... Junio or anyone else: thoughts? The following changes since commit 0233b800c838ddda41db318ee396320b3c21a560: Merge branch 'maint' (2016-02-17 10:14:39 -0800) are available in the git repository at: git://bogomips.org/git-svn.git ks/svn-pathnameencoding-3 for you to fetch changes up to 980c083276ba06a9400c5b1b2558c3626bcff969: git-svn: apply "svn.pathnameencoding" before URL encoding (2016-02-20 23:30:16 +0000) ---------------------------------------------------------------- Kazutoshi Satoda (2): git-svn: enable "svn.pathnameencoding" on dcommit git-svn: apply "svn.pathnameencoding" before URL encoding perl/Git/SVN/Editor.pm | 4 +++- t/t9115-git-svn-dcommit-funky-renames.sh | 39 ++++++++++++++++++++++++++++++-- 2 files changed, 40 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html