Jeff King <peff@xxxxxxxx> writes: > I wonder, though, if this function before or after is actually correct; > if there is no encoding header, we exit the function immediately. But if > we are changing the encoding from utf8 to a non-utf8 value, we > presumably should continue and actually insert the new encoding header. The function is correct; the only reason it may recode to non-utf8 is the user (or Porcelain such as qgit or gitk) explicitly asked to do so -- from the final output they will get the message in user-native encoding and without the extra encoding header, thus we retain the backward compatible behaviour before the re-encoding feature was introduced. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html