Alexander Kuleshov <kuleshovmail@xxxxxxxxx> writes:
> We are trying to extract dirname from argv0 in the git_extract_argv0_path().
> But in the same time, the <git-compat-util.h> provides find_last_dir_sep()
> to get dirname from a given path. Let's use it instead of loop for the code
> simplification.
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
> ---
Looks correct. Thanks.
> exec_cmd.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/exec_cmd.c b/exec_cmd.c
> index e85f0fd..680b257 100644
> --- a/exec_cmd.c
> +++ b/exec_cmd.c
> @@ -43,12 +43,10 @@ const char *git_extract_argv0_path(const char *argv0)
>
> if (!argv0 || !*argv0)
> return NULL;
> - slash = argv0 + strlen(argv0);
>
> - while (argv0 <= slash && !is_dir_sep(*slash))
> - slash--;
> + slash = find_last_dir_sep(argv0);
>
> - if (slash >= argv0) {
> + if (slash) {
> argv0_path = xstrndup(argv0, slash - argv0);
> return slash + 1;
> }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html