On Thu, Feb 18, 2016 at 11:46 PM, Jeff King <peff@xxxxxxxx> wrote: > To trigger a credential fetch in actual use, you have to clone over > http. See the credential tests in t5550, for example. > I'll look at these. >> As for how to whitelist config to share with the submodule I am really >> not 100% sure, since we just clear GIT_CONFIG_PARAMETERS, and I think >> we'd need a specialized variant of clear_local_git_env_vars specific >> to submodule then. > > Yeah, you'll have to parse, which is pretty painful. In C, you'd do > something like: <snip> > > but right now git-submodule.sh is all in shell. You'd probably need a > special helper from git-submodule--helper, though it might simply make > sense to put this off until the submodule code is fully ported to C. > I think the best approach is probably to put this off since I am not 100% sure how we'd handle environment variables from swapping into submoduler--helper and out. That seems really finicky and likely to go away once the full port occurs so I am not sure it's worth it. > -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html