Michael Haggerty <mhagger@xxxxxxxxxxxx> writes:
> * Don't capitalize error strings
> * Report true paths of affected files
Obvious improvements. Good.
> Signed-off-by: Michael Haggerty <mhagger@xxxxxxxxxxxx>
> ---
> Maybe these error strings should be internationalized? If so, there
> are a bunch of similar error strings in related functions that should
> be changed at the same time.
>
> refs/files-backend.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index e5f964c..4266da9 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -2430,10 +2430,11 @@ static int rename_tmp_log(const char *newrefname)
> ret = raceproof_create_file(path, rename_tmp_log_callback, &true_errno);
> if (ret) {
> if (true_errno==EISDIR)
> - error("Directory not empty: %s", path);
> + error("directory not empty: %s", path);
> else
> - error("unable to move logfile "TMP_RENAMED_LOG" to logs/%s: %s",
> - newrefname, strerror(true_errno));
> + error("unable to move logfile %s to %s: %s",
> + git_path(TMP_RENAMED_LOG), path,
> + strerror(true_errno));
> }
>
> free(path);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html