On Wed, Feb 17, 2016 at 02:34:08PM -0800, Junio C Hamano wrote: > * jk/tighten-alloc (2016-02-15) 18 commits > - ewah: convert to REALLOC_ARRAY, etc > - convert ewah/bitmap code to use xmalloc > - diff_populate_gitlink: use a strbuf > - transport_anonymize_url: use xstrfmt > - git-compat-util: drop mempcpy compat code > - sequencer: simplify memory allocation of get_message > - test-path-utils: fix normalize_path_copy output buffer size > - fetch-pack: simplify add_sought_entry > - fast-import: simplify allocation in start_packfile > - write_untracked_extension: use FLEX_ALLOC helper > - use st_add and st_mult for allocation size computation > - convert trivial cases to FLEX_ARRAY macros > - use xmallocz to avoid size arithmetic > - convert trivial cases to ALLOC_ARRAY > - add helpers for allocating flex-array structs > - harden REALLOC_ARRAY and xcalloc against size_t overflow > - tree-diff: catch integer overflow in combine_diff_path allocation > - add helpers for detecting size_t overflow > > Update various codepaths to avoid manually-counted malloc(). > > Will merge to 'next'. Please hold off a bit; I have a re-roll coming for this one. > * nd/dwim-wildcards-as-pathspecs (2016-02-10) 3 commits > - get_sha1: don't die() on bogus search strings > - check_filename: tighten dwim-wildcard ambiguity > - checkout: reorder check_filename conditional > > "git show 'HEAD:Foo[BAR]Baz'" did not interpret the argument as a > rev, i.e. the object named by the the pathname with wildcard > characters in a tree object. > > I lost track of this topic; did we decide that this is a good thing > to do, or unnecessary noise to only cater to a crazy use case? I think what we ended up with (and what you have queued here) is an improvement. I had some question about the tip one, which is a kind-of follow-on, and makes the error message you get in certain cases a bit less non-specific. You were "on the fence...but slightly inclined to take" it. Even if we drop it, I think the first two patches are an improvement. -Peff [1] http://article.gmane.org/gmane.comp.version-control.git/285935 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html