On Wed, Feb 17, 2016 at 5:19 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jeff King <peff@xxxxxxxx> writes: >> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote: >>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >>> > From: Jeff King <peff@xxxxxxxx> >>> > >>> > We don't do any post-processing on the resulting strbufs, so it is >>> > simpler to just use string_list_split, which takes care of removing >>> > the delimiter for us. >>> > >>> > Written-by: Jeff King <peff@xxxxxxxx> >>> >>> Perhaps Peff can give his sign-off... >> >> Ah, right. I usually sign-off when sending to the list, so the version >> he pulled from GitHub didn't have it. >> >> Definitely: >> >> Signed-off-by: Jeff King <peff@xxxxxxxx> >> >> And I don't think "Written-by" was doing much here, anyway; I am already >> the author by the From header at the top. :) > > ;-). > > So, is everybody happy with this round? Yes, v6 looks good to me and is: Reviewed-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html