Re: [PATCH 2/3] rebase: move cleanup code to exit_rebase()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>

This patch could use a little bit more verbose commit message IMHO. At
this point it's not completely clear why you need to move this code to
git--rebase-lib.sh.

My understanding is that you want to have this code in the lib.h file to
allow the toplevel to "exec" the helpers which does not allow the
toplevel to do the cleanup afterwards. Hence you need exit_rebase in the
lib to call it from each helper.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]