Jeff King <peff@xxxxxxxx> writes: > On Tue, Feb 16, 2016 at 04:12:08PM -0800, Junio C Hamano wrote: > >> > To be honest, though, I am now on the fence, considering the possible >> > whitespace issue. >> >> Certainly not having to see s[0]->buf over and over is a huge win ;-). >> >> Is the "whitespace issue" a big deal? Does it involve more than a >> similar sibling to string_list_split() that trims the whitespace >> around the delimiter (or allows a regexp as a delimiter "\s*,\s*")? > > I think that solution would work (and IMHO would actually be preferable > to the split-then-trim that strbuf_split does). But it does mean writing > new code. True, but only when we decide to support trimming the whitespace, which can come later. I do not even know if it is wise to accept %(align:position=left, width=4) when %(align:position=left,width=4) would do the job just fine. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html