On 15 Feb 2016, at 18:41, Jeff King <peff@xxxxxxxx> wrote: > On Mon, Feb 15, 2016 at 11:17:44AM +0100, larsxschneider@xxxxxxxxx wrote: > >> From: Lars Schneider <larsxschneider@xxxxxxxxx> >> >> Git should not be on the left-hand side of a pipe, because it hides the exit >> code, and we want to make sure git does not fail. > > I think this is a nice cleanup. > >> There is one more occurrence of this pattern in t9010-svn-fe.sh which is to >> evolved to change it easily. > > The final sentence in the commit message needs s/to/too/. OK! > However, I'm > not sure this is the only remaining case. Doing: > > git grep -E 'git.*[^|]\|($|[^|])' > > shows quite a few. I guess you just looked for "nul_to_q". There is > certainly no need to fix all of them, but you may want to note the > extent of your grepping in your commit message. Yes, I looked only for nul_to_q... there are more than 1000 other cases. I thought about a clever sed script to fix the easy ones but I don't think it is worth the effort. Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html