On Mon, Feb 15, 2016 at 4:51 PM, Jeff King <peff@xxxxxxxx> wrote:
> Each of these cases can be converted to use ALLOC_ARRAY or
> REALLOC_ARRAY, which has two advantages:
>
> 1. It automatically checks the array-size multiplication
> for overflow.
>
> 2. It always uses sizeof(*array) for the element-size,
> so that it can never go out of sync with the declared
> type of the array.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
> diff --git a/compat/mingw.c b/compat/mingw.c
> index 77a51d3..0eabe68 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -854,7 +854,7 @@ static char **get_path_split(void)
> if (!n)
> return NULL;
>
> - path = xmalloc((n+1)*sizeof(char *));
> + ALLOC_ARRAY(path, n+1);
Elsewhere in this patch, you've reformatted "x+c" as "x + c"; perhaps
do so here, as well.
> p = envpath;
> i = 0;
> do {
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html