In builtin/remote.c there are a few cases which check whether a remote
exists or not. These checks are however done inconsistently, and in a
few cases they don't check anything at all. This patch series tries
to improve the situation.
I stumbled upon this when I mistyped the remote name in git remote rm,
and got a cryptic error message, and thought the other cases might be
worth fixing as well.
There is one such check left in get_remote_ref_states, but I'm not
quite sure what to do about that one. That function gets called in
git remote show/set-head/prune, where it might make sense for the user
to provide a url, or a local repository, at least in the git remote
show case.
I think we have the following options there:
(1) just remove the check, as nobody seems to have noticed until now,
and the check doesn't actually do anything (get_remote() is never
called with NULL, so it will never return NULL). In this case
git dies when a non-existent remote is encountered, e.g. git
remote show nonexistent existent will die immediately, while git
remote show existent nonexistent will show info about the
existing remote, and die afterwards.
(2) add an option not to die in the transport function, and let the
caller of get_remote_ref_states handle the error i.e. show the
error and keep going with the next remote.
(3) anything I might be missing?
Thomas Gummerer (4):
remote: use skip_prefix
remote: simplify remote_is_configured()
remote: actually check if remote exits
remote: use remote_is_configured() for add and rename
builtin/fetch.c | 5 ++---
builtin/remote.c | 23 ++++++++++-------------
remote.c | 22 +++++-----------------
remote.h | 4 ++--
t/t5505-remote.sh | 36 ++++++++++++++++++++++++++++++++++++
5 files changed, 55 insertions(+), 35 deletions(-)
--
2.7.1.410.g6faf27b
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html