On Thu, Feb 11, 2016 at 6:03 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > This introduces a new helper function in git submodule--helper > which takes care of cloning all submodules, which we want to > parallelize eventually. > > Some tests (such as empty URL, update_mode=none) are required in the > helper to make the decision for cloning. These checks have been > moved into the C function as well (no need to repeat them in the > shell script). > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > --- > builtin/submodule--helper.c | 236 ++++++++++++++++++++++++++++++++++++++++++++ > git-submodule.sh | 45 +++------ > 2 files changed, 247 insertions(+), 34 deletions(-) > > diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c > index f4c3eff..e865fca 100644 > --- a/builtin/submodule--helper.c > +++ b/builtin/submodule--helper.c > @@ -255,6 +255,241 @@ static int module_clone(int argc, const char **argv, const char *prefix) > return 0; > } > > +static int git_submodule_config(const char *var, const char *value, void *cb) > +{ > + return submodule_config(var, value, cb); > +} This is the thing I forgot to address. Next reroll will inline submodule_config directly. Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html