Re: man git-config inconsistency (*.fsckObjects)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 08, 2016 at 02:41:44PM +0000, Markus Kuhn wrote:

> https://www.kernel.org/pub/software/scm/git/docs/git-config.html
> 
> The git-config(1) man page entries for "fetch.fsckObjects" and
> "receive.fsckObjects" both end with the lines
> 
>            Defaults to false. If not set, the value of transfer.fsckObjects is
>            used instead.
> 
> These two sentences contradict each other: if the variable is not set,
> the first sentence says it is interpreted as false, the second sentence
> says the value of transfer.fsckObjects is used instead.
> 
> Both sentences can't be true at the same time when transfer.fsckObjects = true.
> 
> Suggested rephrasing:
> 
>            If not set, the value of transfer.fsckObjects is used
>            instead, which defaults to false.

Yeah, I agree your phrasing is much clearer.

> From f6253cce1a0f9df53b020c5821e9fc9fa27cd23f Mon Sep 17 00:00:00 2001
> From: Markus Kuhn <Markus.Kuhn@xxxxxxxxxxxx>
> Date: Mon, 8 Feb 2016 14:36:22 +0000
> Subject: [PATCH] avoid self-contradiction on fsckObjects default
> 
> ---
>  Documentation/config.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

I think the text in your email would make a good commit message. :)

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]