Re: [PATCH] t9100: fix breakage when SHELL_PATH is not /bin/sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 07, 2016 at 08:11:37PM +0100, Michael J Gruber wrote:

> bcb11f1 (mingw: mark t9100's test cases with appropriate prereqs, 2016-01-27)
> replaced "/bin/sh" in exec.sh by the shell specified in SHELL_PATH, but
> that breaks the subtest which checks for a specific checksum of a tree
> containing.
> 
> Revert that change that was not explained in the commit message anyways
> (exec.sh is never executed).

I think this just re-breaks things on Windows. That first setup test
used "chmod +x" (which is brought back by your patch), without having
the POSIXPERM prerequisite.

We probably do not want to mark the whole setup test as POSIXPERM, as
that would effectively break all of the other tests on Windows. The rest
of the tests need to be able to work whether or not the "chmod +x" was
run. It may be simpler to just break the executable-bit tests, including
setup, out to their own section of the script.

That being said, t9100 seems to pass for me, even at bcb11f1. Can you
show us the breakage you are seeing?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]