On Fri, Feb 05, 2016 at 04:59:52PM -0500, Eric Sunshine wrote: > On Fri, Feb 05, 2016 at 11:29:06PM +0200, Dan Aloni wrote: > > It used to be that: > > > > git config --global user.email "(none)" > > > > was a viable way for people to force themselves to set user.email in > > each repository. This was helpful for people with more than one > > email address, targeting different email addresses for different > > clones, as it barred git from creating commit unless the user.email > > Either: s/commit/a commit/ or s/commit/commits/ Thanks for all the proofing in your reply. >[..] > > config was set in the per-repo config to the correct email address. > > > > A recent change, 19ce497c (ident: keep a flag for bogus > > default_email, 2015-12-10), however declared that an explicitly > > s/however/&,/ > > > configured user.email is not bogus, no matter what its value is, so > > this hack no longer works. > > > > Provide the same functionality by adding a new configuration > > variable user.useConfigOnly; when this variable is set, the > > user must explicitly set user.email configuration. > > > > Signed-off-by: Dan Aloni <alonid@xxxxxxxxx> > > Helped-by: Jeff King <peff@xxxxxxxx> > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > > Cc: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > > You'd generally place your sign-off last. > [..] Good to know :) > This test script still has a fair amount of unnecessary cruft in it > which obscures the important bits showing what you are really > testing. Below is a more concise version with the unnecessary stuff > removed: Thanks, though I'll stick to what Jeff suggested. Also, perhaps better to keep 'test_config' as it is instead of using '-c', to better mimick the tested use case. -- Dan Aloni -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html