On Thu, 2016-02-04 at 02:37 -0500, Jeff King wrote:
> On Thu, Jan 14, 2016 at 11:26:10AM -0500, David Turner wrote:
>
> > +static int dereference_symrefs(struct ref_transaction
> > *transaction,
> > + struct strbuf *err)
> > +{
> > + int i;
> > + int nr = transaction->nr;
> > +
> > + for (i = 0; i < nr; i++) {
> > + struct ref_update *update = transaction
> > ->updates[i];
> > + const char *resolved;
> > + unsigned char sha1[20];
> > + int resolve_flags = 0;
> > + int mustexist = (update->old_sha1 &&
> > + !is_null_sha1(update->old_sha1));
>
> Coverity complains about this last line, as "update->old_sha1" is an
> array. I think you want to check "update->flags & REF_HAVE_OLD"
> instead?
Yeah, that's right. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html