On Wed, Feb 3, 2016 at 3:08 AM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote: > Are there any more reviews on this? I do have some changes from this > set, but they're pretty minor so I don't want to post a new one (unless > folks would rather see those changes before reviewing). Let me know. I think you need to keep "refs" directory back somehow. Without it (e.g. "git init --ref-storage=lmdb" does not create "refs"), is_git_directory() from _old_ git versions fails to recognize this is a good repository. So instead of dying on finding an unsupported repository, setup code keeps on looking for another repository in parent directories. If I accidentally run "git add something" with an old binary, "something" could be added to a wrong repository. Very confusing. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html