Stefan Beller <sbeller@xxxxxxxxxx> writes: > Adhere to the common coding style of Git and not check explicitly > for NULL throughout the file. There are still other occurrences in the > code base but that is usually inside of conditions with side effects. > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > submodule-config.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/submodule-config.c b/submodule-config.c > index 4239b0e..6d01941 100644 > --- a/submodule-config.c > +++ b/submodule-config.c > @@ -265,7 +265,7 @@ static int parse_config(const char *var, const char *value, void *data) > if (!strcmp(item.buf, "path")) { > if (!value) > ret = config_error_nonbool(var); > - else if (!me->overwrite && submodule->path != NULL) > + else if (!me->overwrite && submodule->path) > warn_multiple_config(me->commit_sha1, submodule->name, > "path"); Good. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html