On Tue, Feb 2, 2016 at 6:07 AM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Mon, Feb 1, 2016 at 5:25 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >> >>> This series cleans up populate_value() in ref-filter, by moving out >>> the parsing part of atoms to separate parsing functions. This ensures >>> that parsing is only done once and also improves the modularity of the >>> code. >>> >>> v1: http://thread.gmane.org/gmane.comp.version-control.git/281180 >>> v2: http://thread.gmane.org/gmane.comp.version-control.git/282563 >>> v3: http://thread.gmane.org/gmane.comp.version-control.git/283350 >>> >>> Changes: >>> * The parsing functions now take the arguments of the atom as >>> function parameteres, instead of parsing it inside the fucntion. >>> * Rebased on top of pu:jk/list-tag-2.7-regression >>> * In strbuf use a copylen variable rather than using multiplication >>> to perform a logical operation. >>> * Code movement for easier review and general improvement. >>> * Use COLOR_MAXLEN as the maximum size for the color variable. >>> * Small code changes. >>> * Documentation changes. >>> * Fixed incorrect style of test (t6302). >>> >>> Karthik Nayak (12): >>> strbuf: introduce strbuf_split_str_omit_term() >>> ref-filter: use strbuf_split_str_omit_term() >>> ref-filter: bump 'used_atom' and related code to the top >>> ref-filter: introduce struct used_atom >>> ref-filter: introduce parsing functions for each valid atom >>> ref-filter: introduce color_atom_parser() >>> ref-filter: introduce parse_align_position() >>> ref-filter: introduce align_atom_parser() >>> ref-filter: align: introduce long-form syntax >>> ref-filter: introduce remote_ref_atom_parser() >>> ref-filter: introduce contents_atom_parser() >>> ref-filter: introduce objectname_atom_parser() >> >> Hmm, 10/12 didn't make it to the list? > > Not surprising. Somehow, Karthik did git-add on the compiled > test-fake-ssh before committing, so the patch sent to the list > contains an rather huge binary resource. I did receive it since I was > a direct addressee of the email; I'll reply to the message on-list > without modifying anything (other than stripping out the binary > resource) so that other reviewers get a chance to see it. Thanks Eric, i didn't notice doing that. -- Regards, Karthik Nayak -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html