Mike Hommey <mh@xxxxxxxxxxxx> writes: > Shouldn't parse_object_buffer also do check_sha1_signature? In general, it shouldn't; its callers are supposed to do it as additional check when/if needed. Callers like the one in fsck.c does not want to die after seeing one bad one. We want to report and keep checking other things. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html