On Sun, Jan 31, 2016 at 02:37:59PM +0100, SZEDER Gábor wrote: > > Quoting John Keeping <john@xxxxxxxxxxxxx>: > > > According to command-list.txt, verify-tag is an ancillary interrogator, > > which means that it should be completed by "git verify-<TAB>" in the > > same way as verify-commit. > > > > Remove it from the list of plumbing commands so that it is treated as > > porcelain and completed. > > I'm not sure. There are commands among the ancillary interrogators > that are basically porcelains (e.g. blame), while some are more like > plumbing (e.g. rerere, rev-parse). In general the completion script > supports the former but not the latter commands. > > Now, the real porcelain-ish way to verify a tag is via 'git tag > -v|--verify', and according to a925c6f165a3 (bash: Classify more > commends out of completion., 2007-02-04), the commit removing > verify-tag from the completed commands, verify-tag was kept around for > backwards compatibility reasons. OTOH verify-commit was introduced in > d07b00b7f31d (verify-commit: scriptable commit signature verification, > 2014-06-23), and as the subject line states it was intended more as a > plumbing command. > > So I think we should keep excluding verify-tag from the list of > porcelain commands in the completion script, and it was an oversight > not to exclude verify-commit as well when it was introduced. I can accept that argument about verify-commit and verify-tag, but listing verify-tag as plumbing is incorrect according to command-list.txt (and thus git(1)). If we're going to classify commands, shouldn't we be consistent in how we do so? > > Signed-off-by: John Keeping <john@xxxxxxxxxxxxx> > > --- > > contrib/completion/git-completion.bash | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/contrib/completion/git-completion.bash > > b/contrib/completion/git-completion.bash > > index 51f5223..250788a 100644 > > --- a/contrib/completion/git-completion.bash > > +++ b/contrib/completion/git-completion.bash > > @@ -728,7 +728,6 @@ __git_list_porcelain_commands () > > write-tree) : plumbing;; > > var) : infrequent;; > > verify-pack) : infrequent;; > > - verify-tag) : plumbing;; > > *) echo $i;; > > esac > > done > > -- > > 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html