Re: [PATCH] Bisect: add checks at the beginning of "git bisect run".

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christian Couder <chriscool@xxxxxxxxxxxxx> writes:

> diff --git a/git-bisect.sh b/git-bisect.sh
> index fda1712..57d6754 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -223,6 +223,14 @@ bisect_replay () {
>  }
>  
>  bisect_run () {
> +    # Check that we have everything to run correctly.
> +    test -d "$GIT_DIR/refs/bisect" || {
> +	echo >&2 'You need to start by "git bisect start".'
> +	echo >&2 'And then by "git bisect bad" and "git bisect good".'
> +	exit 1
> +    }
> +    bisect_next_check fail
> +

I think you shouldn't need the first "test -d blah"; doesn't
"bisect_next_check fail" already give that message?

>      while true
>      do
>        echo "running $@"
> -- 
> 1.5.1.rc2.2.gcc08

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]