On Thu, Jan 28, 2016 at 10:51:23PM +0000, Eric Wong wrote:
> While working in connect.c to perform non-blocking connections,
> I noticed calling "git fetch -v" was not causing the progress
> messages inside git_tcp_connect_sock to be emitted as I
> expected.
>
> Looking at history, it seems connect_setup has never been called
> with the verbose parameter. Since transport already has a
> "verbose" field, use that field instead of another parameter
> in connect_setup.
That makes sense, but...
> -static int connect_setup(struct transport *transport, int for_push, int verbose)
> +static int connect_setup(struct transport *transport, int for_push)
> {
> struct git_transport_data *data = transport->data;
> + int flags = transport->verbose > 0 ? CONNECT_VERBOSE : 0;
Do we want to trigger this only for "transport->verbose > 1"?
Right now, "git fetch -v" gives us a verbose status table (i.e.,
includes up-to-date refs), but no more debugging than that. Should we
reserve more debug-ish information like for "git fetch -vv"?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html