On Thu, Jan 28, 2016 at 1:25 PM, Matthias Aßhauer <mha1993@xxxxxxx> wrote: >> You had some good measurements in the coverletter, which is not going to be recorded in the projects history. This part however would be part of the commit. >> So you could move the speed improvements here (as well as the other reasoning) on why this is a good idea. :) > > I considered that, but I thought it would inflate the size of the commit message quite a bit and represents a pretty temporary information as I'm planning to port more code. No worries about too large commit messages. ;) See dcd1742e56ebb944c4ff62346da4548e1e3be675 as an example for commit message per code raio what Jeff usually produces. :) > Any further progression on this would make the old meassurements kind of obsolete IMHO. Well it records that this specific step was beneficial, too, on the platforms you measured on. If it turns out to there is a regression after you rewrote lots of code, it is still traceable that this commit was done in good faith. > I decided to move it to the coverletter, because it is only valid information if you consider both commits. If the general opinion on here is that I should add it to the commit message though, I'll gladly update it. Heh, true. However you enable the speedup in the second patch. If you were to apply only the first (add the helper), you'd not see the difference, so maybe it's worth adding it to the second commit message. > >>> https://github.com/git/git/pull/191 >> >> Oh I see you're using the pull-request to email translator, cool! > > Yes, I did. It definitly makes things easier if you are not used to mailing lists, but it was also a bit of a kerfuffle. I tried to start working on coverletter support, but I couldn't get it to accept the amazon SES credentials I provided. I ended up manually submiting the coverletter. It also didn't like my name. Not sure if Roberto, the creator of that tool, follows the mailing list. I cc'd him. > > Thank you for your quick feedback. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html