On Mon, Mar 26, 2007, Jakub Narebski wrote:
> On Sun, Mar 25, 2007, Martin Koegler wrote:
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 5214050..fbadab4 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -2376,6 +2376,7 @@ sub git_patchset_body {
>>
>> my $patch_idx = 0;
>> my $patch_line;
>> + my $empty = 0;
>> my $diffinfo;
>> my (%from, %to);
>>
>> @@ -2396,6 +2397,7 @@ sub git_patchset_body {
>> # git diff header
>> #assert($patch_line =~ m/^diff /) if DEBUG;
>> #assert($patch_line !~ m!$/$!) if DEBUG; # is chomp-ed
>> + $empty++;
>> push @diff_header, $patch_line;
>>
>> # extended diff header
[...]
> First, programming style. You named the variable $empty, when it
> evaluates to true when the patch is _not_ empty, i.e. when some
> differences are found.
By the way, I _think_ that you can use $patch_idx instead of creating
new variable for that.
--
Jakub Narebski
Poland
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html