Hi Eric, On Tue, 26 Jan 2016, Eric Sunshine wrote: > On Tue, Jan 26, 2016 at 9:35 AM, Johannes Schindelin > <johannes.schindelin@xxxxxx> wrote: > > MSYS2 actually allows to create files or directories whose names contain > > tabs, newlines or colors, even if plain Win32 API cannot access them. > > As we are using an MSYS2 bash to run the tests, such files or > > directories are created successfully, but Git itself has no chance to > > work with them because it is a regular Windows program, hence limited by > > the Win32 API. > > [...] > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > diff --git a/t/t3600-rm.sh b/t/t3600-rm.sh > > @@ -14,7 +14,8 @@ test_expect_success \ > > -if touch -- 'tab embedded' 'newline > > + > > Is this new blank line intentional? Absolutely not! ;-) Fixed. > > +if ! test_have_prereq MINGW && touch -- 'tab embedded' 'newline > > [...] > > +test_have_prereq !MINGW && > > Where negation is concerned, is there a non-obvious reason that this > patch sometimes says: > > ! test_have_prereq MINGW > > and sometimes: > > test_have_prereq !MINGW > > ? Is one form preferred over the other? Hysterical raisins. I changed all of them to the latter form, as suggested by Junio. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html