On Mon, Jan 25, 2016 at 4:48 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi Junio, > > On Sun, 24 Jan 2016, Junio C Hamano wrote: > >> Johannes Schindelin <johannes.schindelin@xxxxxx> writes: >> >> > From: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> >> > >> > The test separator char is a colon which means any absolute paths on >> > Windows confuse the tests that use global_excludes. >> > >> > Suggested-by: Karsten Blees <karsten.blees@xxxxxxxxx> >> > Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> >> > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> >> > --- >> > t/t0008-ignores.sh | 8 +++++++- >> >> Is the fact that $global_excludes is specified using an absolute >> path significant to the correctness of this test script? > > Apparently not. So I followed your suggestion and made this independent > of the OS: > > https://github.com/dscho/git/commit/0b9eb308 > >> A larger question is if it would make more sense for Git ported to >> Windows environment to use semicolon (that is the element separator >> for %PATH% in the Windows land, right?) instead where POSIXy port >> would use colon as the separator. A variable that is a list of >> locations (e.g. $PATH) makes little sense when elements can only be >> relative paths in practice. > > Oh my... I was not looking for more work ;-) > > Seriously again, I do agree with the suggestion to use semicolons on > Windows as path lists' separators instead of colons. It definitely makes things easier from the MSYS2 path conversion perspective. Anything that can be done to make this easier is hugely appreciated. > > Ciao, > Dscho > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html