Re: [PATCH] pager: default to LESS=FRX not LESS=FRSX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bill Lear <rael@xxxxxxxxxx> writes:

> On Monday, March 26, 2007 at 01:44:34 (-0700) Junio C Hamano writes:
>>"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes:
>>
>>> Junio C Hamano <junkio@xxxxxxx> wrote:
>>>> Eygene Ryabinkin <rea-git@xxxxxxxxxxx> writes:
>>>> 
>>>> > Remove unnecessary '-S' option that enabled less to chop long lines.
>>>> > It used to provide some confusion at least for the 'git diff':
>>>> > "Where are my long lines? Are they missed from the patch?".
>>>> 
>>>> It is not "unnecessary", but only "what _you_ are not used to".
>>>> As this breaks expectentions of people already familiar with
>>>> what git does by default, I cannot take this patch.
>>>
>>> Hear hear.  I completely agree with Junio.  I (and a number of
>>> other users that I work with) expect this behevaior by default.
>>
>>Two tips.
>>
>> (1) Learn to use left/right arrow keys under "less -S" if you
>>     have occasional lines that are too long.
>
> Hmm, looking at the code: why, if the environment variable LESS is
> already set, should this all be worth talking about?  Shouldn't the
> user be able to set LESS to whatever they want, once, and be done with
> it?  The current setenv() call to set up the pager does this, correct?

Yes.  That would make the third tip ;-).

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]