David Turner <dturner@xxxxxxxxxxxxxxxx> writes: >> The first break is correct, but I am not sure about the "else if" >> part. Shouldn't it be doing something similar to the logic to "keep >> looking" that talks about "t-i", "t" and "t/a" at the end of the >> loop? > > Rather than doing more complicated logic, let's just do the first > check; it seems about as fast for our repo, and I think will usually be > so. does that seem reasonable to you? Very reasonable. I was mostly afraid of leaving the loop prematurely and giving a wrong answer to the caller. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html