Stefan Beller <sbeller@xxxxxxxxxx> writes:
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 6fce0dc..ab0f209 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -130,6 +130,7 @@ cmd_add()
> {
> # parse $args after "submodule ... add".
> reference_path=
> + submodule_groups=
This can just be called $groups in the context of this script. I do
not foresee we would be planning to deal with other kinds of groups
here.
> while test $# -ne 0
> do
> case "$1" in
> @@ -165,6 +166,10 @@ cmd_add()
> --depth=*)
> depth=$1
> ;;
> + -g|--group)
> + submodule_groups=${submodule_groups:+${submodule_groups};}"$2"
> + shift
> + ;;
You would want to accept "--group=<name>" as well, just like
existing --reference and --depth do. It won't be much more code,
and when you move to C (hence parse_options) you'd get it for free
anyway.
> @@ -292,6 +297,16 @@ Use -f if you really want to add it." >&2
>
> git config -f .gitmodules submodule."$sm_name".path "$sm_path" &&
> git config -f .gitmodules submodule."$sm_name".url "$repo" &&
> + if test -n "$submodule_groups"
> + then
> + OIFS=$IFS
> + IFS=';'
I do not quite understand the choice of ';' here. If and only if
you _must_ accept multi-word name that has spaces in between as a
group name, the above construct may make sense, but I do not think
we have such requirement. Why not separate with $IFS letters just
like any other normal list managed in shell scripts do? Is there
anything special about names of submodule groups?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html